something may be wrong

Mar 14, 2013 at 9:01 AM
Path: \nodexl-70521\NodeXL\Layouts\Layouts\HarelKoren\HarelKorenFastMultiscaleLayoutInternal.cs
Line: 253 (maybe)
Code: " if (Math.Abs(C) < eps && Math.Abs(C) < eps) "


Should it be " if (Math.Abs(C) < eps && Math.Abs(E) < eps) "?
Coordinator
Mar 15, 2013 at 6:43 PM
Well, there is clearly something wrong with the line of code you pointed out.

The person who wrote the Harel-Koren layout, which is definitely one of the more complicated parts of NodeXL (it's over a thousand lines of dense calculations), is no longer around. I don't understand the algorithm myself, so I can't be 100% sure that your revision is the correct one. Were you comparing NodeXL's code to another implementation when you discovered this? If so, is that what the other implementation did?

Thanks,
Tony
Mar 16, 2013 at 2:49 AM
Hi Tony.
Thank you for your reply.
Harel-Koren layout in NodeXL is the only code I've studied so far. As a fresh man, I'm not sure whether something's wrong with the code either. In my opinoin, it is only a minor mistake that doesn't matter in the normal cases. It is my shallow understanding and just for your information.